Trim away netframework targets in source-build #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Mar 9, 2023
| @@ -2,6 +2,7 @@ | |||
| <PropertyGroup> | |||
| <GitHubRepositoryName>razor</GitHubRepositoryName> | |||
| <SourceBuildManagedOnly>true</SourceBuildManagedOnly> | |||
| <SourceBuildTrimNetFrameworkTargets>true</SourceBuildTrimNetFrameworkTargets> | |||
There was a problem hiding this comment.
Is there some documentation on what actions this actually takes?
There was a problem hiding this comment.
Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
cc @mmitche for additional context if needed
There was a problem hiding this comment.
@333fred This essentially just avoids building net4* TFMs when building Linux source build.
333fred
approved these changes
Mar 10, 2023
|
Thanks @333fred - can you merge this PR? I don't have permissions. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likerazor.Fixes: #7071