handle params array in the argument list #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
May 1, 2021
...rosoft.NetCore.Analyzers/Runtime/CSharpForwardCancellationTokenToInvocationsFixer.Visitor.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
May 1, 2021
.../UnitTests/Microsoft.NetCore.Analyzers/Runtime/ForwardCancellationTokenToInvocationsTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
suggested changes
May 1, 2021
There was a problem hiding this comment.
Can you also add a test for an API shaped like this:
public virtual System.Threading.Tasks.Task<object> FindAsync (params object[] keyValues);
public virtual System.Threading.Tasks.Task<object> FindAsync (System.Threading.CancellationToken cancellationToken, params object[] keyValues);
The current analyzer/codefixer was intentionally designed to not consider this. I'll get this PR in and then follow up with a re-write allowing cancellation tokens to be in any position. |
Codecov Report
@@ Coverage Diff @@
## main #5082 +/- ##
==========================================
- Coverage 95.60% 95.50% -0.11%
==========================================
Files 1200 1203 +3
Lines 276345 276824 +479
Branches 16633 16696 +63
==========================================
+ Hits 264212 264375 +163
- Misses 9963 10249 +286
- Partials 2170 2200 +30 |
|
@carlossanlop Can you please review this PR? |
|
Tagging @ryzngard for review |
ryzngard
approved these changes
Jun 3, 2021
...etCore.Analyzers/Runtime/CSharpForwardCancellationTokenToInvocationsFixer.TypeNameVisitor.cs
Show resolved
Hide resolved
...etCore.Analyzers/Runtime/CSharpForwardCancellationTokenToInvocationsFixer.TypeNameVisitor.cs
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| if (symbol.NullableAnnotation() == NullableAnnotation.Annotated && |
There was a problem hiding this comment.
Is it possible for symbol.NullableAnnotation() to return Annotated for value types?
...zers/Core/Microsoft.NetCore.Analyzers/Runtime/ForwardCancellationTokenToInvocations.Fixer.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+34
to
+39
| While arrayType IsNot Nothing | ||
| Dim commaCount = Math.Max(0, arrayType.Rank - 1) | ||
| Dim commas = SyntaxFactory.TokenList(Enumerable.Repeat(SyntaxFactory.Token(SyntaxKind.CommaToken), commaCount)) | ||
| ranks.Add(SyntaxFactory.ArrayRankSpecifier(SyntaxFactory.Token(SyntaxKind.OpenParenToken), commas, SyntaxFactory.Token(SyntaxKind.CloseParenToken))) | ||
| arrayType = TryCast(arrayType.ElementType, IArrayTypeSymbol) | ||
| End While |
There was a problem hiding this comment.
nit: you're just digging into through symbol.ElementType here and above. Can we just combine into a single loop?
...NetCore.Analyzers/Runtime/BasicForwardCancellationTokenToInvocationsFixer.TypeNameVisitor.vb
Outdated
Show resolved
Hide resolved
...NetCore.Analyzers/Runtime/BasicForwardCancellationTokenToInvocationsFixer.TypeNameVisitor.vb
Show resolved
Hide resolved
…/ForwardCancellationTokenToInvocationsTests.cs Co-authored-by: Youssef Victor <[email protected]>
…ardCancellationTokenToInvocations.Fixer.cs Co-authored-by: Andrew Hall <[email protected]>
jmarolf
force-pushed
the
bugfix/pass-cancelation-token-with-params-array-overload
branch
from
aaf4736
to
dc448ea
Compare
jmarolf
deleted the
bugfix/pass-cancelation-token-with-params-array-overload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4842
TODO: