Don't emit CA1064 in executables #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7234 +/- ##
========================================
Coverage 96.49% 96.49%
========================================
Files 1443 1443
Lines 345670 345799 +129
Branches 11370 11374 +4
========================================
+ Hits 333552 333677 +125
- Misses 9240 9241 +1
- Partials 2878 2881 +3 |
buyaa-n
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Thank you @CollinAlpert for the fix, as discussed in the issue we don't want to exclude exception types from CA1515, instead it's better to exclude diagnostic for CA1064 Exceptions should be public: in executable.
- Please revert the
Exclude exception types from CA1515part from the PR, looks you also did some code refactoring for the analyzer we can accept that part. - If you are interested fixing the issue by excluding CA1064 diagnostics for executable, that will be great, but not required
|
Thanks for the hint, I have reverted the change to CA1515 and tweaked CA1064. |
CollinAlpert
changed the title
buyaa-n
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Left a few comments, overall looks great, thank you @CollinAlpert!
src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs
Show resolved
Hide resolved
...tAnalyzers/CSharp/Microsoft.CodeQuality.Analyzers/Maintainability/CSharpMakeTypesInternal.cs
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/MakeTypesInternal.cs
Outdated
Show resolved
Hide resolved
buyaa-n
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected analyzers: MakeTypesInternal, ExceptionsShouldBePublicAnalyzer
Affected diagnostic IDs: CA1515, CA1064
This PR ensures that exception types are not suggested to be made internal, as this could conflict with CA1064.
Fixes #7191