Reduce calls to GetUsedNamedTypes to only those types for which the data is needed. #7311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7311 +/- ##
=======================================
Coverage 96.47% 96.48%
=======================================
Files 1443 1443
Lines 345400 345392 -8
Branches 11364 11363 -1
=======================================
+ Hits 333239 333240 +1
+ Misses 9282 9272 -10
- Partials 2879 2880 +1 |
…id before (but on demand now)
|
Closing this PR as there isn't evidence that the users that are experiencing this slowdown are using a package version that includes a different optimization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** marking as draft until I can profile this properly ***