Handle BinaryOperation-return in UseConcreteTypeAnalyzer #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7319 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 1443 1443
Lines 345450 345438 -12
Branches 11364 11364
=======================================
- Hits 333323 333312 -11
+ Misses 9250 9249 -1
Partials 2877 2877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected analyzer: UseConcreteTypeAnalyzer
Affected diagnostic ID: CA1859
This PR prevents false positives of CA1859 when a method's return contains a binary operation.
Fixes #7317