Dispose workspaces when we're done with them

dotnet · Jul 31, 2023 · 55d4ea0 · 55d4ea0
1 parent aa308ec
commit 55d4ea0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Features/Lsif/Generator/Program.cs b/src/Features/Lsif/Generator/Program.cs
@@ -203,7 +203,7 @@ private static async Task GenerateWithMSBuildWorkspaceAsync(
 
             var solutionLoadStopwatch = Stopwatch.StartNew();
 
-            var msbuildWorkspace = MSBuildWorkspace.Create(await Composition.CreateHostServicesAsync());
+            using var msbuildWorkspace = MSBuildWorkspace.Create(await Composition.CreateHostServicesAsync());
             msbuildWorkspace.WorkspaceFailed += (s, e) => logFile.WriteLine("Error while loading: " + e.Diagnostic.Message);
 
             var solution = await openAsync(msbuildWorkspace, cancellationToken);
@@ -266,7 +266,7 @@ private static async Task GenerateFromBinaryLogAsync(
             await logFile.WriteLineAsync($"Load of the binlog complete; {msbuildInvocations.Length} invocations were found.");
 
             var lsifGenerator = Generator.CreateAndWriteCapabilitiesVertex(lsifWriter, logFile);
-            var workspace = new AdhocWorkspace(await Composition.CreateHostServicesAsync());
+            using var workspace = new AdhocWorkspace(await Composition.CreateHostServicesAsync());
 
             foreach (var msbuildInvocation in msbuildInvocations)
             {