Skip to content

Commit

Permalink
remove long gone owners (#68755)
Browse files Browse the repository at this point in the history
  • Loading branch information
danmoseley authored Jun 27, 2023
1 parent 01dc829 commit 5779db1
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions src/Compilers/Core/MSBuildTask/CanonicalError.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ namespace Microsoft.CodeAnalysis.BuildTasks
///
/// <text> : warning [num]: <msg>
/// </remarks>
/// <owner>JomoF</owner>
internal static class CanonicalError
{
// Defines the main pattern for matching messages.
Expand Down Expand Up @@ -141,7 +140,6 @@ internal static class CanonicalError
/// <summary>
/// Represents the parts of a decomposed canonical message.
/// </summary>
/// <owner>JomoF</owner>
internal sealed class Parts
{
/// <summary>
Expand Down Expand Up @@ -237,7 +235,6 @@ internal Parts()
/// </summary>
/// <param name="value"></param>
/// <returns>'value' converted to int or 0 if it can't be parsed or is negative</returns>
/// <owner>LukaszG</owner>
private static int ConvertToIntWithDefault(string value)
{
int result;
Expand All @@ -255,7 +252,6 @@ private static int ConvertToIntWithDefault(string value)
/// Decompose an error or warning message into constituent parts. If the message isn't in the canonical form, return null.
/// </summary>
/// <remarks>This method is thread-safe, because the Regex class is thread-safe (per MSDN).</remarks>
/// <owner>JomoF</owner>
/// <param name="message"></param>
/// <returns>Decomposed canonical message, or null.</returns>
internal static Parts? Parse(string message)
Expand Down
3 changes: 0 additions & 3 deletions src/Compilers/Core/MSBuildTask/Csc.cs
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ internal static void AddReferencesToCommandLine(
/// thing for csc.exe, the IDE compiler cannot support it. In this situation
/// the return value will also be false.
/// </summary>
/// <owner>RGoel</owner>
private bool InitializeHostCompiler(ICscHostObject cscHostObject)
{
bool success;
Expand Down Expand Up @@ -659,7 +658,6 @@ private bool InitializeHostCompiler(ICscHostObject cscHostObject)
/// NoActionReturnSuccess Host compiler was already up-to-date, and we're done.
/// NoActionReturnFailure Bad parameters were passed into the task.
/// </summary>
/// <owner>RGoel</owner>
protected override HostObjectInitializationStatus InitializeHostObject()
{
if (HostObject != null)
Expand Down Expand Up @@ -746,7 +744,6 @@ protected override HostObjectInitializationStatus InitializeHostObject()
/// This method will get called during Execute() if a host object has been passed into the Csc
/// task. Returns true if the compilation succeeded, otherwise false.
/// </summary>
/// <owner>RGoel</owner>
protected override bool CallHostObjectToExecute()
{
Debug.Assert(HostObject != null, "We should not be here if the host object has not been set.");
Expand Down
2 changes: 0 additions & 2 deletions src/Compilers/Core/MSBuildTask/ManagedCompiler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,6 @@ protected bool HostCompilerSupportsAllParameters
/// support a particular parameter or variation on a parameter. So we log a comment,
/// and set our state so we know not to call the host object to do the actual compilation.
/// </summary>
/// <owner>RGoel</owner>
protected void CheckHostObjectSupport
(
string parameterName,
Expand Down Expand Up @@ -1172,7 +1171,6 @@ internal void InitializeHostObjectSupportForNewSwitches(ITaskHost hostObject, re
/// <summary>
/// Checks to see whether all of the passed-in references exist on disk before we launch the compiler.
/// </summary>
/// <owner>RGoel</owner>
protected bool CheckAllReferencesExistOnDisk()
{
if (null == References)
Expand Down
3 changes: 0 additions & 3 deletions src/Compilers/Core/MSBuildTask/Vbc.cs
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,6 @@ internal static string? GetDefineConstantsSwitch
/// thing for csc.exe, the IDE compiler cannot support it. In this situation
/// the return value will also be false.
/// </summary>
/// <owner>RGoel</owner>
private bool InitializeHostCompiler(IVbcHostObject vbcHostObject)
{
this.HostCompilerSupportsAllParameters = this.UseHostCompilerIfAvailable;
Expand Down Expand Up @@ -1012,7 +1011,6 @@ private static bool DeferToICompilerOptionsHostObject(string? langVersion, IVbcH
/// NoActionReturnSuccess Host compiler was already up-to-date, and we're done.
/// NoActionReturnFailure Bad parameters were passed into the task.
/// </summary>
/// <owner>RGoel</owner>
protected override HostObjectInitializationStatus InitializeHostObject()
{
if (this.HostObject != null)
Expand Down Expand Up @@ -1099,7 +1097,6 @@ protected override HostObjectInitializationStatus InitializeHostObject()
/// task. Returns true if an appropriate host object was found, it was called to do the compile,
/// and the compile succeeded. Otherwise, we return false.
/// </summary>
/// <owner>RGoel</owner>
protected override bool CallHostObjectToExecute()
{
Debug.Assert(this.HostObject != null, "We should not be here if the host object has not been set.");
Expand Down

0 comments on commit 5779db1

Please sign in to comment.