Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITextBufferExtensions.GetFeatureOnOffOption does not get per-document options. #17342

Closed
jmarolf opened this issue Feb 24, 2017 · 0 comments · Fixed by #17347
Closed

ITextBufferExtensions.GetFeatureOnOffOption does not get per-document options. #17342

jmarolf opened this issue Feb 24, 2017 · 0 comments · Fixed by #17347
Labels
Area-IDE

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Feb 24, 2017

ITextBufferExtensions.GetFeatureOnOffOption does not get per-document options. it only gets the workspace ones. This means that anything that calls this to see if an option is set will not correctly react to editor config (such as OrganizeDocumentCommandHandler for sort usings).
@jmarolf jmarolf mentioned this issue Feb 24, 2017
Merged
jmarolf added a commit that referenced this issue Feb 24, 2017
@jmarolf
Merge pull request #17347 from jmarolf/bugfix/have-add-imports-check-…
8d401fd 
…option

Pass per-document options when organizing imports or usings
fixes #17342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass per-document options when organizing imports or usings jmarolf/roslyn
2 participants
@gafter @jmarolf