Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pdb path feature flag #19592

Open
jaredpar opened this issue May 17, 2017 · 1 comment
Open

Remove pdb path feature flag #19592

jaredpar opened this issue May 17, 2017 · 1 comment
Assignees
@jaredpar @chsienki
Labels
Area-Compilers Bug
Milestone
Backlog

Comments

@jaredpar
Copy link
Member

This work item tracks the removal of the feature flag pdb-path-determinism. This feature flag was a place holder for having a long term solution around the embedded pdb path be deterministic across different soucre enlistments. This can now be achieved with the /pathmap option and hence the feature flag should be removed.

Deferring removal until a major release to avoid breaking any dependencies in existing build systems.
@jaredpar jaredpar added this to the 16.0 milestone May 17, 2017
@jaredpar jaredpar self-assigned this May 17, 2017
@jaredpar jaredpar mentioned this issue May 17, 2017
Merged
jaredpar added a commit to jaredpar/roslyn that referenced this issue May 17, 2017
@jaredpar
Emitted pdb path should respect PathMap
aaab10b 
The PDB path which is written into the PE file should respect the
`/pathmap` option passed to the compiler.  This is necessary to ensure
that PEs can be deterministic when built from different source paths.

The feature flag `pdb-path-determinism` is being kept for the time
being.  Even though it's a feature flag it still seems inappropriate to
break customers in a point release.  Deferring the removal until the
next major release to give customers time to react.  This issue tracks
removing the flag:

dotnet#19592

closes dotnet#9813
jaredpar added a commit that referenced this issue May 18, 2017
@jaredpar
Emitted pdb path should respect PathMap
b66f68c 
The PDB path which is written into the PE file should respect the
`/pathmap` option passed to the compiler.  This is necessary to ensure
that PEs can be deterministic when built from different source paths.

The feature flag `pdb-path-determinism` is being kept for the time
being.  Even though it's a feature flag it still seems inappropriate to
break customers in a point release.  Deferring the removal until the
next major release to give customers time to react.  This issue tracks
removing the flag:

#19592

closes #9813
@agocke agocke mentioned this issue Nov 11, 2017
Merged
@jkotas jkotas mentioned this issue Mar 3, 2018
Open
@OmarTawfik
Copy link
Contributor

This should also be revisited when it is fixed:
3267090
We're currently validating file names (for back-compat reasons), and we should no longer need to.

@jinujoseph jinujoseph modified the milestones: 16.0, 16.3 Jun 9, 2019
@jcouv jcouv modified the milestones: 16.3, Compiler.Next Jul 11, 2019
@chsienki chsienki self-assigned this Sep 19, 2019
@spouliot spouliot mentioned this issue Sep 1, 2021
Closed
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredpar jaredpar

@chsienki chsienki

Labels
Area-Compilers Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@jaredpar @jinujoseph @jcouv @OmarTawfik @chsienki