Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement designator restrictions for C# 9.0 patterns #40533

Closed
gafter opened this issue Dec 20, 2019 · 1 comment
Closed

Implement designator restrictions for C# 9.0 patterns #40533

gafter opened this issue Dec 20, 2019 · 1 comment
Assignees
@gafter
Labels
Area-Compilers Feature Request New Language Feature - Pattern Matching Pattern Matching
Milestone
Compiler.Net5

Comments

@gafter
Copy link
Member

gafter commented Dec 20, 2019 •
edited by jcouv
Loading

In the currently proposed C# 9.0 pattern-matching extensions, it is forbidden to declare a designator in a pattern that is beneath a not or or pattern combinator. This needs to be implemented in the prototype.

Relates to dotnet/csharplang#2850
@gafter gafter added this to the Compiler.Net5 milestone Dec 20, 2019
@gafter gafter self-assigned this Dec 20, 2019
gafter pushed a commit to gafter/roslyn that referenced this issue Dec 21, 2019
Implement designator restrictions for C# 9.0 patterns
0fdf370 
Fixes dotnet#40533
@gafter gafter mentioned this issue Dec 21, 2019
Merged
gafter pushed a commit that referenced this issue Jan 6, 2020
Implement designator restrictions for C# 9.0 patterns (#40543)
c0e6baf 
Fixes #40533
Relates to dotnet/csharplang#2850
Relates to #40727 (test plan for C# 8 patterns)
@gafter
Copy link
Member Author

gafter commented Jan 6, 2020

Fixed in #40543

@gafter gafter closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Feature Request New Language Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
Compiler.Net5
Development

No branches or pull requests
1 participant
@gafter