Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: allow adding a namespace declaration #51398

Closed
tmat opened this issue Feb 22, 2021 · 1 comment
Closed

EnC: allow adding a namespace declaration #51398

tmat opened this issue Feb 22, 2021 · 1 comment
Assignees
Labels
Area-Interactive Concept-Continuous Improvement Interactive-EnC User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@tmat
Copy link
Member

tmat commented Feb 22, 2021

Prereq: #54939

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 22, 2021
@tmat tmat added this to the 16.10 milestone Feb 22, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 24, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
@tmat tmat self-assigned this Aug 5, 2021
@davidwengier
Copy link
Contributor

This is also the cause of the user issue reported in https://developercommunity.visualstudio.com/t/Hot-reload-Blazor-Server-not-working-wit/1491335

The scenario is straight forward and even repros in a simple console application.

  1. Create new Console Application
  2. Set a breakpoint on the first line
  3. F5
  4. Add new class in Visual Studio

Even though adding a new class is a supported edit, because of the presence there is a new NamespaceDeclaration node in the syntax tree, a rude edit is reported, blocking any other scenario. The scenario in the devcomm reported issue is even simpler, in that the user is adding a class and then making it partial, so there is no semantic difference at all.

@mikadumont mikadumont added the User Story A single user-facing feature. Can be grouped under an epic. label Apr 6, 2022
@tmat tmat modified the milestones: Backlog, 17.3 P2 Jul 21, 2022
@tmat tmat closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interactive Concept-Continuous Improvement Interactive-EnC User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

4 participants