-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file scoped namespace rude edits #55178
Fix file scoped namespace rude edits #55178
Conversation
edits.VerifyRudeDiagnostics( | ||
Diagnostic(RudeEditKind.Delete, null, FeaturesResources.namespace_)); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since file scoped namespaces can't appear with top level code, can't be nested, and can't have multiple in a file, these two tests count as full coverage 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we should follow up with allowing adding/changing namespace as long as it doesn't change any type's qualified name: #51398. |
* upstream/main: (442 commits) Update dependencies from https://github.com/dotnet/source-build build 20210728.1 (dotnet#55226) Update dependencies from https://github.com/dotnet/arcade build 20210728.2 (dotnet#55225) Support EditorBrowsable in Fully-Qualify Add a global using test (dotnet#55180) Fix file scoped namespace rude edits (dotnet#55178) Improve test (dotnet#55200) Update eng/pipelines/insert.yml Update eng/pipelines/insert.yml Remove diagnostic logs fix authorization and publishdata retrieval Add more logging to figure out why vsbranchname is empty restore Only use syntax Work fix comment [main] Update dependencies from dotnet/source-build (dotnet#55046) Update dependencies from https://github.com/dotnet/arcade build 20210727.2 (dotnet#55181) Update test name Remove experimentation for imports on paste Update template to ignore default value ...
@RikkiGibson did most of the worst for this, but missed a couple of spots 😉