Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompilationOutputInfo.AssemblyPath is null for projects in MSBuildWorkspace #51609

Closed
pranavkm opened this issue Mar 3, 2021 · 0 comments · Fixed by #51671
Closed

CompilationOutputInfo.AssemblyPath is null for projects in MSBuildWorkspace #51609

pranavkm opened this issue Mar 3, 2021 · 0 comments · Fixed by #51671
Assignees
@tmat
Labels
Area-IDE Concept-Continuous Improvement
Milestone
16.10

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Mar 3, 2021

Version Used: 3.9.0

Steps to Reproduce:

var msw = MSBuildWorkspace.Create();
var project = await msw.OpenProjectAsync("..");
Console.WriteLine(project.CompilationOutputInfo.AssemblyPath);

Expected Behavior:

This should print the same value as project.OutputFilePath

Actual Behavior:

Value is null. This API gets used to calculate the location of pdbs here which is the only reason it's interesting. An alternative to fixing this would be to update the service to use Project.OutputFilePath instead which is something #35065 hints at ❓.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 3, 2021
pranavkm added a commit that referenced this issue Mar 4, 2021
@pranavkm
Configure CompilationOutputInfo for projects created using an MSBuild…
2d4802d 
…Workspace

In an MSBuildWorkspace, we would expect the compilation output path to be the same
as the project output path. Consequently, it seems fairly safe to default this.

Fixes #51609
@pranavkm pranavkm mentioned this issue Mar 4, 2021
Merged
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 4, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Mar 4, 2021
pranavkm added a commit that referenced this issue Mar 4, 2021
@pranavkm
Configure CompilationOutputInfo for projects created using an MSBuild…
3d685b3 
…Workspace (#51671)

In an MSBuildWorkspace, we would expect the compilation output path to be the same
as the project output path. Consequently, it seems fairly safe to default this.

Fixes #51609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
16.10
Development

Successfully merging a pull request may close this issue.

Configure CompilationOutputInfo for projects created using an MSBuildWorkspace dotnet/roslyn
3 participants
@tmat @pranavkm @jinujoseph