Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Loghub logfile names conflict between liveshare and always active server #51680

Closed
dibarbet opened this issue Mar 4, 2021 · 0 comments · Fixed by #51684
Closed

[LSP] Loghub logfile names conflict between liveshare and always active server #51680

dibarbet opened this issue Mar 4, 2021 · 0 comments · Fixed by #51684
Assignees
@dibarbet
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@dibarbet
Copy link
Member

dibarbet commented Mar 4, 2021

Was looking at logs with the LSP client team to debug an issue and noticed that both the LiveShareInProcLanguageClient and AlwaysActiveInProcLanguageClient have the same log file name because they have the same client name

https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Core/Def/Implementation/LanguageClient/InProcLanguageServer.cs#L150

We should include the type name here to differentiate these two.

E.g. in this screenshot, the first log is the AlwaysActiveInProcLanguageClient, and the second is LiveShareInProcLanguageClient. It is not a single server that has been restarted.

MicrosoftTeams-image (17)
@dibarbet dibarbet added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Mar 4, 2021
@dibarbet dibarbet self-assigned this Mar 4, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 4, 2021
@dibarbet dibarbet mentioned this issue Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibarbet dibarbet

Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lsp server name to log name dibarbet/roslyn
1 participant
@dibarbet