Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lsp server name to log name #51684

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Add lsp server name to log name #51684

merged 2 commits into from
Mar 5, 2021

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Mar 5, 2021

Now looks like
image

Resolves #51680

@dibarbet dibarbet added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Mar 5, 2021
@dibarbet dibarbet requested a review from a team as a code owner March 5, 2021 01:35
davidwengier
davidwengier approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InProcLanguageServer currently passes in a server name to the RequestExecutionQueue, I wonder if its worth passing it in to InProcLanguageServer so they're the same?

@dibarbet dibarbet merged commit 688dfc3 into dotnet:main Mar 5, 2021
@dibarbet dibarbet deleted the fix_log_names branch March 5, 2021 19:54
@allisonchou allisonchou added this to the Next milestone Mar 12, 2021
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@allisonchou allisonchou allisonchou approved these changes

Assignees
No one assigned
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
16.10.P2
Development

Successfully merging this pull request may close these issues.

[LSP] Loghub logfile names conflict between liveshare and always active server
3 participants
@dibarbet @davidwengier @allisonchou