Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure XmlDocCommentCompletionProvider works with records #52738

Closed
Youssef1313 opened this issue Apr 19, 2021 · 2 comments · Fixed by #53052
Closed

Make sure XmlDocCommentCompletionProvider works with records #52738

Youssef1313 opened this issue Apr 19, 2021 · 2 comments · Fixed by #53052
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Completion New Language Feature - Records Records
Milestone

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Apr 19, 2021

As a follow-up to #52737

Also when reordering parameters, such as what currently happens with methods:

[Fact, Trait(Traits.Feature, Traits.Features.ReorderParameters)]
public void ReorderParamTagsInDocComments_SingleLineDocComments_OnIndividualLines()
{
var markup = @"
public class C
{
/// <param name=""a""></param>
/// <param name=""b""></param>
/// <param name=""c""></param>
void $$Goo(int a, int b, int c)
{
}
}";
var permutation = new[] { 2, 1, 0 };
var updatedCode = @"
public class C
{
/// <param name=""c""></param>
/// <param name=""b""></param>
/// <param name=""a""></param>
void Goo(int c, int b, int a)
{
}
}";
TestReorderParameters(LanguageNames.CSharp, markup, permutation: permutation, expectedUpdatedInvocationDocumentCode: updatedCode);
}

@jcouv, This may require parallel record structs work.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 19, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2021
@jinujoseph jinujoseph added this to the Backlog milestone Apr 20, 2021
@jinujoseph jinujoseph added the IDE-IntelliSense Completion, Signature Help, Quick Info label Apr 20, 2021
@jinujoseph
Copy link
Contributor

cc @CyrusNajmabadi

@Youssef1313
Copy link
Member Author

I'm working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Completion New Language Feature - Records Records
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants