Handle records in documentation comments in IDE side #52737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -270,6 +270,7 @@ public static bool IsEmbeddedStatementOwner([NotNullWhen(returnValue: true)] thi | |||
| SyntaxKind.ParenthesizedLambdaExpression => ((ParenthesizedLambdaExpressionSyntax)declaration).ParameterList, | |||
| SyntaxKind.LocalFunctionStatement => ((LocalFunctionStatementSyntax)declaration).ParameterList, | |||
| SyntaxKind.AnonymousMethodExpression => ((AnonymousMethodExpressionSyntax)declaration).ParameterList, | |||
| SyntaxKind.RecordDeclaration => ((RecordDeclarationSyntax)declaration).ParameterList, | |||
There was a problem hiding this comment.
note to @jcouv to have this in the record-struct branch.
CyrusNajmabadi
approved these changes
Apr 19, 2021
92 tasks
jinujoseph
added
the
Community
|
@CyrusNajmabadi Is this ready to merge? |
|
Pinging @CyrusNajmabadi. |
CyrusNajmabadi
approved these changes
May 2, 2021
ghost
added this to the 
|
thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #52663.
The thing left for that issue is:
@jcouv Please add this to record structs test plan. Thanks.