Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename constantly failing in MAUI Apps #65397

Closed
333fred opened this issue Nov 12, 2022 · 11 comments · Fixed by #65818
Closed

Rename constantly failing in MAUI Apps #65397

333fred opened this issue Nov 12, 2022 · 11 comments · Fixed by #65818
Assignees
Labels
Milestone

Comments

@333fred
Copy link
Member

333fred commented Nov 12, 2022

Version Used: 17.5p1 public

Steps to Reproduce:

  1. Create a new .NET MAUI App
  2. Open a CS file, insert a method named M.
  3. Attempt to rename the method to M2.

Expected Behavior:

Method is renamed

Actual Behavior:

image

It does not appear to work correctly with any combination of old/new rename UI or async/sync rename.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 12, 2022
@jasonmalinowski jasonmalinowski removed the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 16, 2022
@333fred
Copy link
Member Author

333fred commented Nov 20, 2022

I will note that changing the name of a thing, and then invoking the rename thing quickfix, does generally seem to work. The other way never does in my MAUI projects.

@333fred
Copy link
Member Author

333fred commented Dec 10, 2022

@ryzngard does your fix also fix non-inline renaming?

@333fred
Copy link
Member Author

333fred commented Dec 10, 2022

Or am I mixing up the ui name with inline rename?

@ryzngard
Copy link
Contributor

@333fred this fixes rename ui that comes from the command invocation, not the lightbulb (called rename tracking)

@DiogoMartinh0
Copy link

When can we expect to be able to use this?

@ryzngard
Copy link
Contributor

@DiogoMartinh0 it should be in 17.5 Preview 2

@DiogoMartinh0
Copy link

Issue seems to still be present in Version 17.5.0 Preview 2.0

@333fred
Copy link
Member Author

333fred commented Dec 14, 2022

There's no way this could have made p2. I'm guessing that was a typo for p3 @ryzngard?

@DiogoMartinh0
Copy link

Merged 4 days before P2 release seemed too close to the release but...

@ryzngard
Copy link
Contributor

Yes, definitely a typo. Preview 3 not 2.

As a work around you can still use rename tracking (rename the item and then use the lightbulb to finish the rename)

@sharwell sharwell added this to the 17.5 P3 milestone Dec 27, 2022
@DiogoMartinh0
Copy link

When is P3 expected to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants