Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilers generated code isn't validated in CI when only source generators are changed #65602

Open
Youssef1313 opened this issue Nov 24, 2022 · 1 comment
Assignees
Milestone

Comments

@Youssef1313
Copy link
Member

Validation is conditioned on compilerChange being true here:

roslyn/azure-pipelines.yml

Lines 237 to 245 in 35ac8cb

displayName: Generate Syntax Files
inputs:
filePath: eng/generate-compiler-code.ps1
arguments: -test -configuration Release
condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true'))
- script: $(Build.SourcesDirectory)\.dotnet\dotnet.exe tool run dotnet-format whitespace $(Build.SourcesDirectory)\src --folder --include-generated --include $(Build.SourcesDirectory)\src\Compilers\CSharp\Portable\Generated\ $(Build.SourcesDirectory)\src\Compilers\VisualBasic\Portable\Generated\ $(Build.SourcesDirectory)\src\ExpressionEvaluator\VisualBasic\Source\ResultProvider\Generated\ --verify-no-changes
displayName: Validate Generated Syntax Files
condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true'))

which is run only if there are changes to src\Compilers or src\Dependencies:

roslyn/azure-pipelines.yml

Lines 206 to 208 in 35ac8cb

include:
- src/Compilers/*
- src/Dependencies/*

If a PR has changes only to the generators, the validation will be incorrectly skipped

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 24, 2022
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 6, 2023
@arunchndr arunchndr added this to the 17.6 milestone Jan 6, 2023
@jasonmalinowski
Copy link
Member

@jmarolf It looks like that condition might go back to #62797 -- is just adding the additional folder to the list that was called out here sufficient, or does more work need to be done? I don't mind sending out the PR if it's a trivial fix but if this takes more work I'm not sure if you should pick this one up? (Or I'll need some explanation of how it works!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants