Disable static restore in more locations #66567
Conversation
| @@ -206,6 +206,7 @@ stages: | |||
| include: | |||
| - src/Compilers/* | |||
| - src/Dependencies/* | |||
| - eng/* | |||
There was a problem hiding this comment.
seems like we should run compiler CI when build scripts change
There was a problem hiding this comment.
Since you are touching this, could you also fix #65602 in this PR?
There was a problem hiding this comment.
Added the compiler generator tools path - let me know if there were other directories you were thinking of
|
Is there a writeup for why disabling static restore fixes correctness jobs? |
It isn't just correctness - it technically affects all the builds with static restore (see the nuget restore issue). However the reason it hit correctness builds first (well technically it hit the scouting queue integration tests first) is that they are specifically requiring an image with VS preview on it (17.5) which has a version of nuget with the issue. |
|
@RikkiGibson or @jaredpar - any idea on what might be happening with the rebuild check? It passed on the previous commit (and I only changed the folders qualifying as a compiler change in the yaml which I don't believe should impact correctness). I already re-ran once and hit the same error |
|
It looks like the bootstrap build is failing in that job. Why only in Rebuild? I don't think any rebuild-specific stuff is happening at that point. |
|
Merging to help unblock PRs. |
ghost
added this to the 
* Disable static restore in more locations * Run compilers CI when build scripts change * Include compiler generators in compilers code change check * Remove separate restore in bootstrap build
* Disable static restore in more locations * Run compilers CI when build scripts change * Include compiler generators in compilers code change check * Remove separate restore in bootstrap build
* Disable static restore in more locations * Run compilers CI when build scripts change * Include compiler generators in compilers code change check * Remove separate restore in bootstrap build
took a quick stab at fixing this