-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate CompilationWithAnalyzers.IsDiagnosticAnalyzerSuppressed public API #67592
Comments
Yes. Let's def deprecate this :) |
…lic API Fixes dotnet#67592 Details in above issue description
Draft PR: #67671 |
API Review
We'll move forward with obsoletion, and investigate how difficult freezing the current implementation will be. If it's easy, then we can remove at the next major version. If it's not, then we'll need to discuss when we want to break the functionality of the API. |
Thanks! I was able to refactor the code in #67671 to freeze the current implementation and also restore the unit tests for this public API, while also cleaning up the code in AnalyzerExecutor and AnalyzerManager for rest of the code paths. |
@mavasani let's send an email to API review and let them know we plan to move forward with the deprecation/removal in the next major version. |
FYI: This proposal was accepted via offline email discussion. |
roslyn/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs
Lines 1224 to 1237 in 5d77712
CompilationWithAnalyzers
was introduced prior to the editorconfig support in the compiler layer and only accounts for severity configurations via rulesets and command line switches.CompilationOptions
, this API can no longer return the correct value when severities are configured in editorconfig/globalconfig files.null
value forcompilation
in lot of internal driver code, which makes the code unnecessarily complex and unintuitive.The text was updated successfully, but these errors were encountered: