Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test code coverage of pattern-matching implementation. #9542

Closed
gafter opened this issue Mar 8, 2016 · 0 comments
Closed

Test code coverage of pattern-matching implementation. #9542

gafter opened this issue Mar 8, 2016 · 0 comments
Assignees
@gafter
Labels
Area-Compilers Bug Language-C# New Language Feature - Pattern Matching Pattern Matching Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Test Test failures in roslyn-CI
Milestone
15.1

Comments

@gafter
Copy link
Member

gafter commented Mar 8, 2016 •
edited
Loading

The pattern-matching implementation started out as a prototype, and reflects a specification that is in flux; it is not in its final production-ready form. The implementation needs to be reviewed in detail against the final specification once it exists, and we should ensure we have code coverage of the relevant code paths of the implementation.
@gafter gafter added this to the 2.0 (RC) milestone Mar 8, 2016
@gafter gafter mentioned this issue Mar 8, 2016
Closed
@AlekseyTs AlekseyTs mentioned this issue Mar 8, 2016
Merged
@jaredpar jaredpar added the Bug label Apr 11, 2016
@gafter gafter mentioned this issue Jul 11, 2016
Merged
@gafter gafter self-assigned this Jul 14, 2016
@gafter gafter modified the milestones: 2.0 (RC), 2.0 (RTM) Jul 18, 2016
@gafter gafter modified the milestones: 2.0 (RC), 2.0 (RTM) Oct 6, 2016
@jcouv jcouv added the Test Test failures in roslyn-CI label Jan 17, 2017
@gafter gafter added this to the 2.1 milestone Feb 3, 2017
@gafter gafter removed this from the 2.0 (RTM) milestone Feb 3, 2017
gafter added a commit to gafter/roslyn that referenced this issue Feb 3, 2017
@gafter
Add tests to improve coverage of pattern-matching implementation.
6ad8b14 
Fixes dotnet#9542
Fixes dotnet#16876
@gafter gafter mentioned this issue Feb 3, 2017
Merged
@gafter gafter added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Feb 3, 2017
gafter added a commit that referenced this issue Feb 15, 2017
@gafter
Add tests to improve coverage of pattern-matching implementation and …
a4d87ea 
…fix a crash. (#16928)

* Add tests to improve coverage of pattern-matching implementation and fix a crash.
Fixes #9542
Fixes #16876 (crash that is fixed)
Fixes #17088
Added tests for #17089
@gafter gafter added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug Language-C# New Language Feature - Pattern Matching Pattern Matching Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Test Test failures in roslyn-CI
Projects
None yet
Milestone
15.1
Development

No branches or pull requests
3 participants
@jaredpar @gafter @jcouv