Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup Request::WriteToPipe #12

Closed
wants to merge 1 commit into from
Closed

Speedup Request::WriteToPipe #12

wants to merge 1 commit into from

Conversation

apolukhin
Copy link

Reserve buffer to avoid reallocations and data copying (not tested)

@apolukhin
Speedup Request::WriteToPipe
df0541c 
Reserve buffer to avoid reallocations and data copying
@theoy theoy added this to the 1.1 milestone Jan 16, 2015
@pharring
Copy link
Contributor

I haven't seen any bottlenecks in this code, but the change looks reasonable.
However, it should be noted that we intend to replace this C++ code with C# in the near future.
(I thought we had an issue tracking that, but I can't find it)

@theoy
Copy link
Contributor

theoy commented Feb 4, 2015

@pharring is right - we're in active planning to replace this component with a managed implementation (issue #137). Thanks a ton for the tip though. We're really appreciative that community members are reviewing the code and proposing improvements. ❤️

@theoy theoy modified the milestones: Unknown, 1.1 Feb 4, 2015
@gafter
Copy link
Member

gafter commented Feb 17, 2015

@Jenkins test this please

@gafter
Copy link
Member

gafter commented Mar 18, 2015

@agocke If this pull request is obsolete, can you please close it?

@gafter
Copy link
Member

gafter commented Apr 5, 2015

Closing this PR, as the relevant code no longer exists.

@gafter gafter closed this Apr 5, 2015
@jaredpar jaredpar removed their assignment Nov 23, 2015
@jaredpar jaredpar removed this from the Unknown milestone Nov 23, 2015
AdamSpeight2008 referenced this pull request in AdamSpeight2008/roslyn-AdamSpeight2008 Feb 17, 2017
@AdamSpeight2008
Use Multi-Line String Literal in VB Unit Tests (#12)
a47fb96
@Neil65 Neil65 mentioned this pull request Apr 12, 2016
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Jul 30, 2018
Closed
@jjonescz jjonescz mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0 - Backlog Area-Compilers Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apolukhin @pharring @theoy @gafter @jaredpar