Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate readonlyattribute if it does not exist #18715

Merged
merged 23 commits into from
May 18, 2017
Merged

Generate readonlyattribute if it does not exist #18715

merged 23 commits into from
May 18, 2017

Commits on Apr 13, 2017

  1. Call this.DeclaringCompilation.EnsureReadOnlyAttributeExists() when n… 

    …eeded
    Omar Tawfik committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d01bccc View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2017

  1. Promote EmbeddedAttribute to be used by both compilers

    Omar Tawfik committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    ea8e8da View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2017

  1. Generate Embedded attributes on PE Module Builder

    Omar Tawfik committed Apr 17, 2017
    Configuration menu
    Copy the full SHA
    389871a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2017

  1. Thread PEModuleBuilder through Symbol.AddSynthesizedAttributes()

    Omar Tawfik committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    45abc25 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2017

  1. Fix failing tests

    Omar Tawfik committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    f14b9b0 View commit details
    Browse the repository at this point in the history

  2. Base case passing

    Omar Tawfik committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    72459ef View commit details
    Browse the repository at this point in the history

  3. Refactor ReadOnlyAttribute to IsReadOnlyAttribute

    Omar Tawfik committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    13e65c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2017

  1. Fix build break

    Omar Tawfik committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    ddf80c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2017

  1. More Tests

    Omar Tawfik committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    801d046 View commit details
    Browse the repository at this point in the history

  2. Clean up

    Omar Tawfik committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    ab6d26c View commit details
    Browse the repository at this point in the history

Commits on May 3, 2017

  1. PR Comments #1 

    PR Comments #3

PR Comments #4

PR Comments #5

PR Comments #6

PR Comments # 7
    Omar Tawfik committed May 3, 2017
    Configuration menu
    Copy the full SHA
    bfb6f8b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2017

  1. Handle NoPIA 

    Added more tests
    Omar Tawfik committed May 4, 2017
    Configuration menu
    Copy the full SHA
    97fdd3b View commit details
    Browse the repository at this point in the history

  2. Lambdas and Local functions no longer generate attributes in symbols 

    Added tests for constructors and operators

Signal need for synthesized attributes in local rewriter for lambdas an local functions

Clean up
    Omar Tawfik committed May 4, 2017
    Configuration menu
    Copy the full SHA
    6738585 View commit details
    Browse the repository at this point in the history

  3. Clean up

    Omar Tawfik committed May 4, 2017
    Configuration menu
    Copy the full SHA
    b75e420 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2017

  1. More PR Feedback

    Omar Tawfik committed May 9, 2017
    Configuration menu
    Copy the full SHA
    639bdb5 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Adding more tests

    Omar Tawfik committed May 10, 2017
    Configuration menu
    Copy the full SHA
    d2d9747 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2017

  1. More PR Comments

    Omar Tawfik authored and Omar Tawfik committed May 11, 2017
    Configuration menu
    Copy the full SHA
    7be6b63 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2017

  1. More tests for explicit interface implementations

    Omar Tawfik committed May 13, 2017
    Configuration menu
    Copy the full SHA
    40748ee View commit details
    Browse the repository at this point in the history

  2. Latest PR Comments

    Omar Tawfik committed May 13, 2017
    Configuration menu
    Copy the full SHA
    f4ce74d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2017

  1. Merge conflicts resolved

    Omar Tawfik committed May 14, 2017
    Configuration menu
    Copy the full SHA
    83f6355 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2017

  1. Moved EnsureIsReadOnlyAttributeExists to AfterAddingTypeMembersChecks

    Omar Tawfik committed May 15, 2017
    Configuration menu
    Copy the full SHA
    f6dc461 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2017

  1. Resolve conflicts

    Omar Tawfik committed May 16, 2017
    Configuration menu
    Copy the full SHA
    0bc8579 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2017

  1. Fix failing tests

    Omar Tawfik committed May 18, 2017
    Configuration menu
    Copy the full SHA
    7042fc6 View commit details
    Browse the repository at this point in the history