Fix build parallelism issue with documentation file generation #22232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GenerateDocumentationFile=true instead of DocumentationFile= $(IntermediateOutputPath)$(AssemblyName).xml. This lets the SDK pick the appropriate path. At the point where the explicit DocumentationFile was being evaluated, the intermediate output path had not yet gotten the TargetFramework appended. As such, parallel builds of the different TargetFrameworks of a multi-targeted project were trying to write the documentation xml to the same intermediate location.
|
https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_release_unit32_prtest/9614/ "xunit produced no error output but had exit code -2146232797" Looks unrelated. Different intermittent issue? |
jasonmalinowski
approved these changes
Sep 21, 2017
|
@nguerrera: yeah, probably a different issue. 😦 |
jaredpar
approved these changes
Sep 21, 2017
|
retest windows_release_unit32_prtest please |
|
retest windows_release_unit64_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GenerateDocumentationFile=true instead of DocumentationFile=$(IntermediateOutputPath)$(AssemblyName).xml. This lets the SDK pick the appropriate path.
At the point where the explicit DocumentationFile was being evaluated, the intermediate output path had not yet gotten the TargetFramework appended. As such, parallel builds of the different TargetFrameworks of a multi-targeted project were trying to write the documentation xml to the same intermediate location.