Allow deconstruction of 'default' literal #25562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
the
PR For Personal Review Only
This was referenced Mar 17, 2018
|
linking to #21232 (would be nice to consider that in lowering) |
jcouv
added a commit
to jcouv/dotnet-ci
that referenced
this pull request
Mar 20, 2018
jcouv
removed
the
PR For Personal Review Only
cston
approved these changes
Mar 20, 2018
|
test windows_debug_unit64_prtest please |
|
test windows_debug_unit64_prtest please |
nnfhhvbb
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This language change needs to be confirmed with LDM, but I think it would make sense to allow (and give
defaultthe type from the left-hand-side). This would be consistent withdefaultbeing allowed in tuple equality ((1, 2) == default).Relates to discussion: dotnet/csharplang#1358
Customer scenario
(int i, string j) = default; // error CS8131: Deconstruct assignment requires an expression with a type on the right-hand-side.(i, s) = default; // error CS8131: Deconstruct assignment requires an expression with a type on the right-hand-side.With this PR, this change becomes allowed.
Bugs this fixes
Fixes #25559
Workarounds, if any
You could write
(default, default)instead.Risk
Performance impact
Low. The only change is to extend the logic to fix the type of tuple literals in deconstructions to also fix the type of
defaultliteral.Is this a regression from a previous update?
No. This is a minor language feature.
Tagging @gafter