-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for base access with explicit base type. #35456
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1713,9 +1713,9 @@ internal enum ErrorCode | |
ERR_LanguageVersionDoesNotSupportDefaultInterfaceImplementationForMember = 8706, | ||
|
||
ERR_RuntimeDoesNotSupportProtectedAccessForInterfaceMember = 8707, | ||
ERR_NotBaseOrImplementedInterface = 8708, | ||
ERR_NotImplementedInBase = 8709, | ||
ERR_NotDeclaredInBase = 8710, | ||
//ERR_NotBaseOrImplementedInterface = 8708, | ||
//ERR_NotImplementedInBase = 8709, | ||
//ERR_NotDeclaredInBase = 8710, | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it may be better to just delete these, since it will likely be inappropriate to include these diagnostics in the C# 8.0 range of codes if it is introduced in a later language version. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One possible reason to keep these error codes is to make it easier to revert this PR later on (to re-introduce the feature). We can reserve those error codes. In reply to: 280623450 [](ancestors = 280623450) |
||
ERR_DefaultInterfaceImplementationInNoPIAType = 8711, | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider inlining declaration