Merge release/dev16.3 to release/dev16.3-vs-deps #38265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se/dev16.3-preview2 Merge release/dev16.2 to release/dev16.3-preview2
… merges/release/dev16.3-preview2-to-release/dev16.3
…-to-release/dev16.3 Merge release/dev16.3-preview2 to release/dev16.3
Before C# 8, the reduction of an extension method would fail (return null) when the method's constraints would not be satisfied. But in C# 8 the unmanaged constraint requires we know the language version, and therefore the compilation, to check. That is not available in `IMethodSymbol.ReduceExtensionMethod`. So we dropped the constraint checking in #37022. However this causes an unfortunate regression in the quality of the IDE experience. So here we restore the constraint checking, using the compilation's language version when available. IMethodSymbol.ReduceExtensionMethod uses the C# 8 rules since it has no language version to check. Fixes #37780
…elease/dev16.3-to-release/dev16.3-vs-deps
|
@dotnet/roslyn-ide In the first run three independent builds failed with multiple different tests failing in completion. This should be investigated to determine if it's a test issue or a product issue at the highest priority |
|
cc @dotnet/roslyn-infrastructure |
…ease/dev16.3-to-release/dev16.3-vs-deps
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from release/dev16.3 into release/dev16.3-vs-deps.
git fetch --all git checkout merges/release/dev16.3-to-release/dev16.3-vs-deps git reset --hard upstream/release/dev16.3-vs-deps git merge upstream/release/dev16.3 # Fix merge conflicts git commit git push upstream merges/release/dev16.3-to-release/dev16.3-vs-deps --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.