Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ExcludeFromCodeCoverageAttribute in local functions #41129

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Support ExcludeFromCodeCoverageAttribute in local functions #41129

merged 4 commits into from
Jan 23, 2020

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jan 21, 2020 •
edited
Loading

Related to #38801

@RikkiGibson RikkiGibson marked this pull request as ready for review January 22, 2020 00:56
@RikkiGibson RikkiGibson requested a review from a team as a code owner January 22, 2020 00:56
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Jan 22, 2020 •
edited by RikkiGibson
Loading

Done with review pass (iteration 2) #Resolved

@AlekseyTs
Copy link
Contributor

Done with review pass (iteration 3)

AlekseyTs
AlekseyTs approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(iteration 4)

@RikkiGibson RikkiGibson mentioned this pull request Jan 23, 2020
Closed
54 tasks
@RikkiGibson RikkiGibson merged commit cce0891 into dotnet:features/local-function-attributes Jan 23, 2020
@RikkiGibson RikkiGibson deleted the lfa-excludefromcodecoverage branch January 23, 2020 02:07
RikkiGibson
RikkiGibson commented Jan 23, 2020
View reviewed changes
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
return RemoveDynamicAnalysisInjectors(previous);
case DebugInfoInjector { Previous: var previous } injector:
var newPrevious = RemoveDynamicAnalysisInjectors(previous);
return (object)newPrevious != previous ? new DebugInfoInjector(newPrevious) : injector;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed that the DebugInfoInjector singleton could be used in the case where newPrevious is the NoOp instrumenter. Will correct in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
Compiler.Next
Development

Successfully merging this pull request may close these issues.
3 participants
@RikkiGibson @AlekseyTs @cston