IOperation support for new pattern forms in C# 9.0. #42474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
New Language Feature - Pattern Matching
18 tasks
|
@gafter you're missing the updated XML file. Will look when that is pushed. |
Change type of INegatedPattern.NegatedPattern and IBinaryPattern.LeftPattern and RightPattern to IPatternOperation
333fred
approved these changes
Mar 18, 2020
|
@agocke Could you please look at this? |
…into patterns3-ioperation
AlekseyTs
reviewed
Mar 18, 2020
| Assert.Same(operation.NegatedPattern, operation.Children.Single()); | ||
| } | ||
|
|
||
| public override void VisitTypePattern(ITypePatternOperation operation) |
There was a problem hiding this comment.
ITypePatternOperation [](start = 46, length = 21)
Consider asserting MatchedType is not null. #Pending
AlekseyTs
reviewed
Mar 18, 2020
| @@ -1120,6 +1120,38 @@ public override void VisitConstantPattern(IConstantPatternOperation operation) | |||
| Assert.Same(operation.Value, operation.Children.Single()); | |||
| } | |||
|
|
|||
| public override void VisitRelationalPattern(IRelationalPatternOperation operation) | |||
There was a problem hiding this comment.
IRelationalPatternOperation [](start = 52, length = 27)
Consider asserting OperatorKind #Pending
gafter
pushed a commit
to gafter/roslyn
that referenced
this pull request
Mar 19, 2020
Also two review fixes from dotnet#42474
gafter
pushed a commit
that referenced
this pull request
Mar 20, 2020
Also two review fixes from #42474
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.