Address some crashes found by fuzz testing. #43280
Conversation
gafter
added
Area-Compilers
New Language Feature - Pattern Matching
|
@agocke @RikkiGibson @dotnet/roslyn-compiler May I please have a couple of reviews of this change to loosen assertions that were too tight (demonstrated by added tests)? |
| @@ -401,7 +401,7 @@ private BoundPattern BindDiscardPattern(DiscardPatternSyntax node, TypeSymbol in | |||
| diagnostics.Add(ErrorCode.ERR_PointerTypeInPatternMatching, typeSyntax.Location); | |||
| return true; | |||
| } | |||
| else if (patternType.IsNullableType() && patternTypeWasInSource) | |||
| else if (patternType.IsNullableType() || typeSyntax is NullableTypeSyntax && patternTypeWasInSource) | |||
There was a problem hiding this comment.
patternType.IsNullableType() || typeSyntax is NullableTypeSyntax [](start = 21, length = 64)
Should this expression be parenthesized? (Should patternTypeWasInSource apply regardless?) #Resolved
There was a problem hiding this comment.
I will remove patternTypeWasInSource. It is always true.
In reply to: 407620967 [](ancestors = 407620967)
| PatternMatchingFuzz(i + k); | ||
| } | ||
| })); | ||
| Task.WaitAll(tasks.ToArray()); |
There was a problem hiding this comment.
Task.WaitAll(tasks.ToArray()) [](start = 12, length = 29)
Is it important that the tests run in parallel rather than sequentially? It's not clear where in PatternMatchingFuzz() there is shared state. If it's not important, consider making this sequential or include a comment. #Resolved
There was a problem hiding this comment.
I have a 32-thread processor on my desk. This is just a way of getting much more testing done per unit time. It is otherwise the same as the adjacent sequential version. Both are skipped. #Resolved
…into patterns3-fuzz
…into patterns3-fuzz
…o patterns3-fuzz
No description provided.