Support init accessor in CSharpSyntaxFacts #48137
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1315,6 +1315,7 @@ private static bool IsMemberDeclaration(SyntaxNode node) | |
| case SyntaxKind.PropertyDeclaration: | ||
| case SyntaxKind.GetAccessorDeclaration: | ||
| case SyntaxKind.SetAccessorDeclaration: | ||
| case SyntaxKind.InitAccessorDeclaration: | ||
|
There was a problem hiding this comment. I don't think it's a good idea to update this one without knowing the change it introduce. This whole method isn't covered in the tests. See how #48158 is green.
Youssef1313 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| case SyntaxKind.EventDeclaration: | ||
| case SyntaxKind.EventFieldDeclaration: | ||
| case SyntaxKind.AddAccessorDeclaration: | ||
|
|
@@ -1756,6 +1757,7 @@ public override bool CanHaveAccessibility(SyntaxNode declaration) | |
| case SyntaxKind.EventFieldDeclaration: | ||
| case SyntaxKind.GetAccessorDeclaration: | ||
| case SyntaxKind.SetAccessorDeclaration: | ||
| case SyntaxKind.InitAccessorDeclaration: | ||
| case SyntaxKind.AddAccessorDeclaration: | ||
| case SyntaxKind.RemoveAccessorDeclaration: | ||
| return true; | ||
|
|
@@ -2006,7 +2008,7 @@ public override DeclarationKind GetDeclarationKind(SyntaxNode declaration) | |
| return DeclarationKind.Attribute; | ||
| } | ||
| break; | ||
| // Add InitAccessor once https://github.com/dotnet/roslyn/issues/48136 is resolved | ||
Youssef1313 marked this conversation as resolved.
Show resolved
Hide resolved
Youssef1313 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| case SyntaxKind.GetAccessorDeclaration: | ||
| return DeclarationKind.GetAccessor; | ||
| case SyntaxKind.SetAccessorDeclaration: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidwengier I removed both GetAccessorDeclaration and InitAccessorDeclaration in a draft. There are no test failures. So the current tests, unfortunately, doesn't cover those.
The usages that depend on this method are in:
syntaxFactsService.IsDeclaration(node)).DescendantNodes(n => !syntaxFacts.IsDeclaration(n)))Unlike the other change, I'm not able to guess the effect of this change.
I'll try to change the method to only
return falsein the draft in a hope to see test failures (i.e. other switch arms are tested).