Allow pattern matching null against pointer types when the pointer types contain nested type parameters
#49915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
changed the title
…e parameters. Fixes dotnet#49639.
333fred
force-pushed
the
func-ptr-null-comparison
branch
from
26b19cc
to
52ccbf4
Compare
|
@dotnet/roslyn-compiler for review. |
AlekseyTs
reviewed
Dec 11, 2020
AlekseyTs
reviewed
Dec 11, 2020
AlekseyTs
reviewed
Dec 11, 2020
AlekseyTs
reviewed
Dec 11, 2020
AlekseyTs
reviewed
Dec 11, 2020
|
Done with review pass (commit 1) #Closed |
|
@AlekseyTs addressed feedback. In reply to: 743462458 [](ancestors = 743462458) |
AlekseyTs
reviewed
Dec 11, 2020
AlekseyTs
approved these changes
Dec 11, 2020
|
@dotnet/roslyn-compiler for a second review of this small change. |
jaredpar
reviewed
Dec 14, 2020
jaredpar
approved these changes
Dec 14, 2020
333fred
changed the title
null against pointer types when the pointer types contain nested type parameters
ghost
added this to the
Done. |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Dec 15, 2020
* upstream/master: (241 commits) Allow pattern matching `null` against pointer types when the pointer types contain nested type parameters (dotnet#49915) Remove document extension method and convert usages to use the text buffer extension method. VB: Strengthen implementation of `PropertySymbol.IsWritable` against NullReferenceException (dotnet#49962) Add switch to skip nullable analysis (dotnet#49876) Update dependencies from https://github.com/dotnet/roslyn build 20201211.16 (dotnet#49958) Treat record positional parameters as properties (dotnet#48329) [master] Update dependencies from dotnet/roslyn (dotnet#49395) VB: Ensure array access indexes undergo conversion to integer even when there is a mismatch with array rank. (dotnet#49907) Disable OOP when running as cloud environment client VS instance Rename workspace context method (and unify impls) to better represent the condition being checked Report non-Const locals used in an expression that must have a constant value. (dotnet#49912) Add support for more ServiceAudience values (dotnet#49914) Handle ref-containing structs returned by value from function-pointers (dotnet#49883) Fix error on out param of extern local function (dotnet#49860) Fix constructor exit warnings for generic NotNull (dotnet#49841) Loc updates Prefer more specific path map key (dotnet#49670) Rename `_availablelocalFunctionOrdinal` to `_availableLocalFunctionOrdinal` (dotnet#49901) Fix namespace so that external access wrapper type can be accessed from UT. XamlProjectService fixes (dotnet#49711) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49639.
I've gone through other references to
IsNonNullableValueType, and none of them need updating. The rest of the uses center around type parameter constraint checking, which function pointers cannot be, and lifted conversion operators, where the underlying value type is being checked with this method, and function pointers cannot be that underlying type.