Enable CA1822 in Visual Studio layer

[Youssef1313]

The issues stated were fixed and closed.

[Youssef1313]

This looks redundant as it's already specified above, but it's required due to #50577

[Youssef1313]

This is the only change to const.

[mavasani]

@Youssef1313 FYI that I already attempted this locally in the past, but there are lot of internal APIs in the VisualStudio layer that are used via IVTs by internal partner teams, so this poses a big risk of introducing breaking changes. I think this will be a risky change and would certainly require validation and approval from @sharwell and @jinujoseph

[Youssef1313]

@Youssef1313 FYI that I already attempted this locally in the past, but there are lot of internal APIs in the VisualStudio layer that are used via IVTs by internal partner teams, so this poses a big risk of introducing breaking changes. I think this will be a risky change and would certainly require validation and approval from @sharwell and @jinujoseph

@mavasani I'm only changing private APIs. Any internal/public APIs are not touched.

[Youssef1313]

@jinujoseph @mavasani Any updates on this? Note that I'm only touching private APIs, which I think aren't exposed via InternalsVisibleTo, so there shouldn't be a problem.

[mavasani]

@Youssef1313 thanks, given it is only for private APIs, it should be fine. I’ll review the PR. Thanks for your patience.

[Youssef1313]

@mavasani This is passing CI now.