Update analyzers

eng/Versions.props

@@ -27,7 +27,7 @@
   </PropertyGroup>
   <PropertyGroup>
     <!-- Versions used by several individual references below -->
-    <RoslynDiagnosticsNugetPackageVersion>3.3.2-beta1.20562.1</RoslynDiagnosticsNugetPackageVersion>
+    <RoslynDiagnosticsNugetPackageVersion>3.3.3-beta1.21105.3</RoslynDiagnosticsNugetPackageVersion>
     <MicrosoftCodeAnalysisNetAnalyzersVersion>6.0.0-preview1.21054.10</MicrosoftCodeAnalysisNetAnalyzersVersion>
     <MicrosoftCodeAnalysisTestingVersion>1.0.1-beta1.20623.3</MicrosoftCodeAnalysisTestingVersion>
     <CodeStyleAnalyzerVersion>3.8.0</CodeStyleAnalyzerVersion>
@@ -66,7 +66,7 @@
       packages we will keep it untied to the RoslynDiagnosticsNugetPackageVersion we use for
       other analyzers to ensure it stays on a release version.
     -->
-    <MicrosoftCodeAnalysisAnalyzersVersion>3.0.0</MicrosoftCodeAnalysisAnalyzersVersion>
+    <MicrosoftCodeAnalysisAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisAnalyzersVersion>
     <MicrosoftCodeAnalysisBuildTasksVersion>2.0.0-rc2-61102-09</MicrosoftCodeAnalysisBuildTasksVersion>
     <MicrosoftCodeAnalysisCSharpAnalyzerTestingXUnitVersion>$(MicrosoftCodeAnalysisTestingVersion)</MicrosoftCodeAnalysisCSharpAnalyzerTestingXUnitVersion>
     <MicrosoftCodeAnalysisCSharpCodeFixTestingXUnitVersion>$(MicrosoftCodeAnalysisTestingVersion)</MicrosoftCodeAnalysisCSharpCodeFixTestingXUnitVersion>

eng/config/globalconfigs/NonShipping.globalconfig

@@ -16,6 +16,10 @@ dotnet_diagnostic.RS1019.severity = none
 dotnet_diagnostic.RS1025.severity = none
 # Enable concurrent execution - suppress for non-shipping/test projects
 dotnet_diagnostic.RS1026.severity = none
+# Define diagnostic message correctly
+dotnet_diagnostic.RS1032.severity = none
+# Define diagnostic description correctly
+dotnet_diagnostic.RS1033.severity = none
 # Do not use generic CodeAction.Create to create CodeAction - not useful for tests
 dotnet_diagnostic.RS0005.severity = none
 # Do not call 'GetTestAccessor()' from production code: does not apply to tests

src/Analyzers/CSharp/Analyzers/CSharpAnalyzersResources.resx

@@ -235,7 +235,7 @@
     <comment>{Locked="readonly"} "readonly" is C# keyword and should not be localized.</comment>
   </data>
   <data name="Struct_contains_assignment_to_this_outside_of_constructor_Make_readonly_fields_writable" xml:space="preserve">
-    <value>Struct contains assignment to 'this' outside of constructor. Make readonly fields writable</value>
+    <value>Struct contains assignment to 'this' outside of constructor. Make readonly fields writable.</value>
     <comment>{Locked="Struct"}{Locked="this"} these are C#/VB keywords and should not be localized.</comment>
   </data>
   <data name="Deconstruct_variable_declaration" xml:space="preserve">

src/Analyzers/Core/Analyzers/AnalyzersResources.resx

@@ -124,7 +124,7 @@
     <value>Remove unused member</value>
   </data>
   <data name="Private_member_0_is_unused" xml:space="preserve">
-    <value>Private member '{0}' is unused.</value>
+    <value>Private member '{0}' is unused</value>
   </data>
   <data name="Remove_unused_private_members" xml:space="preserve">
     <value>Remove unused private members</value>
@@ -133,7 +133,7 @@
     <value>Remove unread private members</value>
   </data>
   <data name="Private_member_0_can_be_removed_as_the_value_assigned_to_it_is_never_read" xml:space="preserve">
-    <value>Private member '{0}' can be removed as the value assigned to it is never read.</value>
+    <value>Private member '{0}' can be removed as the value assigned to it is never read</value>
   </data>
   <data name="Private_method_0_can_be_removed_as_it_is_never_invoked" xml:space="preserve">
     <value>Private method '{0}' can be removed as it is never invoked.</value>

src/Analyzers/Core/Analyzers/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs

@@ -28,11 +28,6 @@ internal abstract class AbstractValidateFormatStringDiagnosticAnalyzer<TSyntaxKi
             AnalyzersResources.ResourceManager,
             typeof(AnalyzersResources));
 
-        private static readonly LocalizableString Description = new LocalizableResourceString(
-            nameof(AnalyzersResources.Invalid_format_string),
-            AnalyzersResources.ResourceManager,
-            typeof(AnalyzersResources));
-
 #pragma warning disable RS0030 // Do not used banned APIs - We cannot use AbstractBuiltInCodeStyleDiagnosticAnalyzer nor AbstractCodeQualityDiagnosticAnalyzer.
         // This analyzer is run against generated code while the abstract base classes mentioned doesn't. The rule is also not documented.
         // There is even a current work to remove the rule completely in favor of CA2241.
@@ -43,7 +38,6 @@ internal abstract class AbstractValidateFormatStringDiagnosticAnalyzer<TSyntaxKi
             DiagnosticCategory.Compiler,
             DiagnosticSeverity.Info,
             isEnabledByDefault: true,
-            description: Description,
             customTags: EnforceOnBuildValues.ValidateFormatString.ToCustomTag());
 #pragma warning restore RS0030 // Do not used banned APIs