Move to a semaphoreslim in the workspace. #51215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
force-pushed
the
asyncWorkspace
branch
from
3258bca
to
05a3950
Compare
sharwell
reviewed
Feb 14, 2021
| @@ -199,7 +199,7 @@ public async Task InitializeUIAffinitizedServicesAsync(IAsyncServiceProvider asy | |||
| var openFileTracker = await OpenFileTracker.CreateAsync(this, asyncServiceProvider).ConfigureAwait(true); | |||
|
|
|||
| // Update our fields first, so any asynchronous work that needs to use these is able to see the service. | |||
| lock (_gate) | |||
| using (_gate.DisposableWait()) | |||
There was a problem hiding this comment.
was initially making just a straight translation. but we can def update tehse calls to be DisposableWaitAsync as well .
sharwell
approved these changes
Feb 14, 2021
Not at all confident. I've already found one case of reentrancy. Though, IMO, these cases are boken as well. In cases of non-virtual calls, it's clear what the right code is. In the case of virtuals, it's not at all clear given that we might have subclasses doing strange things. So definitely concerning. |
|
CLosing out for now. I don't feel this can be done particularly safely. We have reentrancy, and there is a lot of virtual calls here that make it difficult to ensure the same behavior and now risk of deadlocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #51138 for independent review.