Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide structured information in binlog for the compiler server #51275

Merged
7 commits merged into from
Feb 19, 2021

Commits on Feb 17, 2021

  1. Remove ErrorOutput

    The `ErrorOutput` field is not used in the compiler protocol because the
    compiler never writes to stderr. This was complicating the code path for
    no good reason and hence I decided to remove it.
    jaredpar committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    ca2ae82 View commit details
    Browse the repository at this point in the history
  2. Clean up the error message path

    Refactor a bit and clean up some comments to help make the flow of data
    a bit clearer here.
    jaredpar committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    6371eee View commit details
    Browse the repository at this point in the history
  3. Structured server error messages

    This change adds structured messages to the binlog about the behavior of
    the compiler server. These messages will help users, our own developers
    and automation understand the behavior of the compiler server within a
    build.
    jaredpar committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    4469be0 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Better log message

    jaredpar committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9acd897 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Apply suggestions from code review

    Co-authored-by: Sam Harwell <[email protected]>
    jaredpar and sharwell authored Feb 19, 2021
    Configuration menu
    Copy the full SHA
    4aed0db View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Rikki Gibson <[email protected]>
    jaredpar and RikkiGibson authored Feb 19, 2021
    Configuration menu
    Copy the full SHA
    073598b View commit details
    Browse the repository at this point in the history
  3. PR feedback

    jaredpar committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    007046d View commit details
    Browse the repository at this point in the history