Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to master-vs-deps #51326

Merged
48 commits merged into from
Feb 19, 2021
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into master-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-master-vs-deps --force

CyrusNajmabadi and others added 6 commits February 18, 2021 13:01
* Create second XAML LSP client without DisableUserExperience set and toggle between them via feature flag

* Share capabilities between the clients
…se/dev16.10

Merge release/dev16.9 to release/dev16.10
Remove dependency on internal VS utility apis.
@dotnet-bot dotnet-bot requested a review from a team as a code owner February 18, 2021 23:55
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Feb 18, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@JoeRobich JoeRobich removed the Merge Conflicts There are merge conflicts with the base branch. label Feb 19, 2021
@RikkiGibson
Copy link
Contributor

@dibarbet could you please address the merge conflicts/build failures in this PR? Feel free to blow away the attempted conflict resolution and push your own resolution up if that is convenient.

@JoeRobich JoeRobich force-pushed the merges/master-to-master-vs-deps branch from f73cd8f to d4c970a Compare February 19, 2021 17:38
@dotnet-bot dotnet-bot requested review from a team as code owners February 19, 2021 17:38
@JoeRobich JoeRobich force-pushed the merges/master-to-master-vs-deps branch from d4c970a to ea7b88f Compare February 19, 2021 21:07
@ghost ghost merged commit f79a9aa into master-vs-deps Feb 19, 2021
@ghost ghost deleted the merges/master-to-master-vs-deps branch February 19, 2021 22:40
@ghost ghost added this to the Next milestone Feb 19, 2021
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants