Perform code-lens 'find' operations serially. #51395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Feb 22, 2021
src/Workspaces/Core/Portable/FindSymbols/FindReferences/FindReferencesSearchEngine.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Feb 22, 2021
src/Workspaces/Core/Portable/FindSymbols/FindReferences/FindReferencesSearchEngine.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Feb 22, 2021
| /// Scheduler to run our tasks on. If we're in <see cref="FindReferencesSearchOptions.Explicit"/> mode, we'll | ||
| /// run all our tasks concurrently. Otherwise, we will run them serially using <see cref="s_exclusiveScheduler"/> | ||
| /// </summary> | ||
| private readonly TaskScheduler _scheduler; |
There was a problem hiding this comment.
💡 At this point, this could be a property.
src/Workspaces/Core/Portable/FindSymbols/SymbolFinder_FindReferences_Legacy.cs
Show resolved
Hide resolved
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeLens both runs in the background, and and is commonly run on many visible symbosl in a file. This leads to a lot of find-references work in our OOP process that is currently done in parallel. This parallel work uses all the cores it can get, and can generally slow down the editing experience in the host VS process as tehre is less CPU available for the jobs it wants to do.
To avoid this problem, this PR adds a new flag to control if we do this sort of work in parallel or not, and updates CodeLens to ask that the work be done serially instead. Existing, explicitly invoked features (like FindReferences) will still do work in parallel so they can get their results back to the usre as quickly as possible.
Fixes AB#1280758