Rebuild as many projects as possible #51427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jaredpar
approved these changes
Feb 25, 2021
| @@ -32,7 +32,8 @@ | |||
| <MicrosoftCodeAnalysisTestingVersion>1.0.1-beta1.20623.3</MicrosoftCodeAnalysisTestingVersion> | |||
| <CodeStyleAnalyzerVersion>3.8.0</CodeStyleAnalyzerVersion> | |||
| <VisualStudioEditorPackagesVersion>16.8.181</VisualStudioEditorPackagesVersion> | |||
| <ILToolsPackageVersion>5.0.0-alpha1.19409.1</ILToolsPackageVersion> | |||
| <ILAsmPackageVersion>5.0.0-alpha1.19409.1</ILAsmPackageVersion> | |||
| <ILDAsmPackageVersion>5.0.0-preview.1.20112.8</ILDAsmPackageVersion> | |||
There was a problem hiding this comment.
Why are we using different versions here?
There was a problem hiding this comment.
When I tried using the same, original version for both, NuGet complained me that it couldn’t find such a version of ildasm and chose the version that you see instead.
cston
reviewed
Feb 25, 2021
|
|
||
| namespace BuildValidator | ||
| { | ||
| public static class IldasmUtilities |
There was a problem hiding this comment.
public [](start = 4, length = 6)
internal?
cston
approved these changes
Feb 25, 2021
jaredpar
approved these changes
Feb 25, 2021
| " --assembliesPath `"$ArtifactsDir/obj/PrepareTests`"" + | ||
| " --assembliesPath `"$ArtifactsDir/obj/RunTests`"" + | ||
| " --assembliesPath `"$ArtifactsDir/obj/vbc/$configuration/netcoreapp3.1`"" + | ||
| " --assembliesPath `"$ArtifactsDir/obj/VBCSCompiler/$configuration/netcoreapp3.1`"" + |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the rebuild leg to rebuild as many bits as possible.
This also introduces some changes to:
Results of rebuilding everything in Roslyn repo are detailed here: https://gist.github.com/RikkiGibson/77cad2adb2e35552aa2008834d6f69a5
Please take a look @tmat @jaredpar @cston