Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language feature status for interpolated string improvements. #51500

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

333fred
Copy link
Member

@333fred 333fred commented Feb 25, 2021

No description provided.

@333fred
Copy link
Member Author

333fred commented Feb 25, 2021

@dotnet/roslyn-compiler for a quick review.

@333fred
Copy link
Member Author

333fred commented Feb 25, 2021

(Note the branch doesn't exist yet, it will shortly)

@333fred 333fred added the Feature - Interpolated String Improvements Interpolated string improvements label Feb 25, 2021
@333fred 333fred requested a review from a team February 25, 2021 22:59
cston
cston previously approved these changes Feb 25, 2021
@333fred
Copy link
Member Author

333fred commented Feb 26, 2021

Highly recommend using the rich diff, as I removed all the extraneous spaces. Unless you have an ultrawide monitor and shrink the text you're not reading the raw markdown table anyway (ask me how I know).

@RikkiGibson
Copy link
Contributor

I honestly have considered changing this table to just straight HTML instead of really long markdown lines that can't be broken up. But that might inspire a different objection from my teammates.

Copy link
Contributor

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested updating the file scoped namespaces too, rather than submitting a second PR ;)

@333fred
Copy link
Member Author

333fred commented Feb 26, 2021

Suggested updating the file scoped namespaces too, rather than submitting a second PR ;)

Now I feel bad, because I just noticed that you had a branch and updated it on my own, and I could have just hit "commit suggestion"

@333fred 333fred merged commit 11660ce into dotnet:master Feb 26, 2021
@ghost ghost added this to the Next milestone Feb 26, 2021
@333fred 333fred deleted the update-language-feature branch February 26, 2021 02:52
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants