EnC support for source-generated files #51526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidwengier PTAL |
davidwengier
approved these changes
Mar 1, 2021
ghost
added this to the
This was referenced Mar 1, 2021
Comment on lines
+357
to
+362
| // Given the following assumptions: | ||
| // - source generators are deterministic, | ||
| // - source documents, metadata references and compilation options have not changed, | ||
| // - additional documents have not changed, | ||
| // - analyzer config documents have not changed, | ||
| // the outputs of source generators will not change. |
There was a problem hiding this comment.
So what's the intent here for project-to-project references? That you're not running? I don't disagree with the decision, I wasn't sure if there were some other cases you have in mind.
There was a problem hiding this comment.
You mean the generator depending on content of other projects to which it gets thru references of the compilation?
There was a problem hiding this comment.
How does the IDE deal with that for other services, like completion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #51420.
Adds ability to detect changes in files generated by source generators: #50283.
Fixes an issue with merging partial type edits.