Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoliCheck fix #51700

Merged
merged 2 commits into from
Mar 5, 2021
Merged

PoliCheck fix #51700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b69e220
remove the word crazy
Cosifne Mar 5, 2021
45aa337
Update src/Features/Core/Portable/GenerateMember/GenerateConstructor/…
Cosifne Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Features/Core/Portable/GenerateMember/GenerateConstructor/GenerateConstructorHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private static bool IsCompatible<TExpressionSyntax>(
// However, theoretically the public type from A could have a user-defined conversion.
// The alternative approach might be to map the type of the parameters back into B, and then
// classify the conversions in Project B, but that'll run into other issues if the experssions
// don't have a natural type (like default). We choose to ignore all potentially crazy cases here.
// don't have a natural type (like default). We choose to ignore all complicated cases here.
return false;
}

Expand Down