Rev codestyle version to 3.9 #52559
Merged
Rev codestyle version to 3.9 #52559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
reviewed
Apr 12, 2021
| @@ -30,7 +30,7 @@ | |||
| <RoslynDiagnosticsNugetPackageVersion>3.3.3-beta1.21105.3</RoslynDiagnosticsNugetPackageVersion> | |||
| <MicrosoftCodeAnalysisNetAnalyzersVersion>6.0.0-preview1.21054.10</MicrosoftCodeAnalysisNetAnalyzersVersion> | |||
| <MicrosoftCodeAnalysisTestingVersion>1.0.1-beta1.20623.3</MicrosoftCodeAnalysisTestingVersion> | |||
| <CodeStyleAnalyzerVersion>3.8.0</CodeStyleAnalyzerVersion> | |||
| <CodeStyleAnalyzerVersion>3.9.0</CodeStyleAnalyzerVersion> | |||
There was a problem hiding this comment.
Interesting, I would have expected at least some new violations on command line with adopting a new CodeStyle package. Is CodeStyle enforcement on build broken? I’ll play around with it today.
There was a problem hiding this comment.
No clue :) i took it to mean that our code is just that awesome.
jmarolf
approved these changes
Apr 12, 2021
|
@mavasani should i merge and we can check things later? or do you want me to hold off? |
Feel free to merge. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.