Ensure that we register to analyze generated code for MakeFieldReadO… #52726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly analyzer Fixes dotnet#50925 Note that we only pass in the `Analyze` flag, not the `ReportDiagnostics` flag, so that fields defined in generated code are not flagged.
mavasani
changed the title
Youssef1313
reviewed
Apr 19, 2021
| @@ -65,10 +65,12 @@ protected AbstractBuiltInCodeStyleDiagnosticAnalyzer(ImmutableArray<DiagnosticDe | |||
| customTags: DiagnosticCustomTags.Create(isUnnecessary, isConfigurable, enforceOnBuild)); | |||
| #pragma warning restore RS0030 // Do not used banned APIs | |||
|
|
|||
| // Code style analyzers should not run on generated code, unless explicitly required by the analyzer. | |||
There was a problem hiding this comment.
Might be better as a doc comment. Probably also extend the statement to say it should either be None or Analyze, but not ReportDiagnostic?
There was a problem hiding this comment.
Probably also extend the statement to say it should either be None or Analyze, but not ReportDiagnostic?
Hmm, I did not want to be so pedantic given we may have some analyzer that also wants to report on generated code? I can actually make this simple by just making this a bool property though, which may make the purpose more explicit.
davidwengier
approved these changes
Apr 19, 2021
sharwell
approved these changes
Apr 19, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nly analyzer
Fixes #50925
Note that we only pass in the
Analyzeflag, not theReportDiagnosticsflag, so that fields defined in generated code are not flagged.