✨ Support a solution-specific analysis scope set through Solution Explorer #52789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Apr 21, 2021
src/VisualStudio/Core/Def/Implementation/VisualStudioAnalysisScopeService.cs
Outdated
Show resolved
Hide resolved
sharwell
commented
Apr 21, 2021
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
sharwell
commented
Apr 21, 2021
Comment on lines
166
to
167
| if (SolutionCrawlerOptions.GetBackgroundAnalysisScope(document.Project) == BackgroundAnalysisScope.ActiveFile && | ||
| _documentTrackingService?.TryGetActiveDocument() != document.Id) |
There was a problem hiding this comment.
I removed this "extra" early return. We still return early from the scheduled task, but the code is cleaner.
sharwell
changed the title
JoeRobich
reviewed
Aug 13, 2021
Only analyzers that use SolutionCrawlerOptions internally need to reanalyze when these options change. The tests are now updated to reflect this change.
jmarolf
approved these changes
Aug 16, 2021
ghost
added this to the 
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Aug 27, 2021
…s-scope"" This reverts commit 381f9db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52768