Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax normalizer to add space around before colon in constructor initializer #53326

Merged
merged 3 commits into from
May 18, 2021
Merged

Fix syntax normalizer to add space around before colon in constructor initializer #53326

merged 3 commits into from
May 18, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 11, 2021 •
edited
Loading

Fixes #53254
Fixes #35371

@Youssef1313 Youssef1313 requested a review from a team as a code owner May 11, 2021 18:57
@Youssef1313 Youssef1313 requested a review from a team as a code owner May 11, 2021 19:42
@Youssef1313
Copy link
Member Author 

  Skipped Microsoft.CodeAnalysis.CSharp.UnitTests.Emit.CovariantReturnTests.SimpleCovariantReturnEndToEndTest [1 ms]
The active test run was aborted. Reason: Test host process crashed : Process is terminated due to StackOverflowException.

@Youssef1313 Youssef1313 reopened this May 11, 2021
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 11, 2021
@jcouv jcouv self-assigned this May 18, 2021
@jcouv jcouv added this to the 17.0 milestone May 18, 2021
jcouv
jcouv approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@jcouv jcouv merged commit bcf00c9 into dotnet:main May 18, 2021
@ghost ghost modified the milestones: 17.0, Next May 18, 2021
@jcouv
Copy link
Member

jcouv commented May 18, 2021

Merged/squashed. Thanks @Youssef1313

@Youssef1313 Youssef1313 deleted the normalize-colon branch May 18, 2021 05:34
333fred added a commit to 333fred/roslyn that referenced this pull request May 20, 2021
@333fred
Merge remote-tracking branch 'upstream/main' into editorformattingser…
e1f3b59 
…vice-featureslayer

* upstream/main: (857 commits)
  Update contrib documentation (dotnet#53504)
  SImplify
  Fix out of bound crash in lsp navto.
  Revert changes to TypeScriptWaitContext wrappers
  Switch to ROSLYN_TEST_CI for CI detection
  SImplify
  Simplify LoggerTestChannel using BlockingCollection
  Only require telemetry validation in CI
  Fix out of bound crash in lsp navto.
  Fix locked comment
  Update Compiler Test Plan.md (dotnet#53420)
  Adjust doc comment for NullableWalker.VisitConversion (dotnet#53429)
  Revert "Infer delegate types with -langversion:preview only (dotnet#53241)" (dotnet#53466)
  Fix syntax normalizer to add space around before colon in constructor initializer (dotnet#53326)
  Remove unnecessary property (dotnet#53406)
  EnC - Tell the debugger about updated type def tokens (dotnet#53217)
  Revert an error
  Update PublishData.json
  Keep trailing trivia so single line if statements don't get badly formatted (dotnet#53414)
  Fix dead test code (dotnet#53416)
  ...
@KirillOsenkov KirillOsenkov mentioned this pull request May 30, 2021
Open
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.0.P2
6 participants
@Youssef1313 @jcouv @CyrusNajmabadi @cston @RikkiGibson @jinujoseph