'with' on anonymous type needs to lower values #54086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
reviewed
Jun 14, 2021
| @@ -183,7 +183,8 @@ public override BoundNode VisitWithExpression(BoundWithExpression withExpr) | |||
| Debug.Assert(left.MemberSymbol is not null); | |||
|
|
|||
| // We evaluate the values provided in source first | |||
| BoundLocal valueTemp = _factory.StoreToTemp(assignment.Right, out BoundAssignmentOperator boundAssignmentToTemp); | |||
| var rewrittenRight = (BoundExpression)Visit(assignment.Right)!; | |||
There was a problem hiding this comment.
Consider using LocalRewriter.VisitExpression which should make the cast and the ! unnecessary
RikkiGibson
approved these changes
Jun 15, 2021
AlekseyTs
reviewed
Jun 15, 2021
| System.Console.WriteLine(adjusted); | ||
| "; | ||
| var comp = CreateCompilation(src, parseOptions: TestOptions.RegularPreview); | ||
| comp.VerifyEmitDiagnostics(); |
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an embarrassing bug (forgot to lower the sub-expressions in this case)...
Fixes #53849
Relates to record structs feature: #51199 (test plan)