Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable add usings on paste by default #55298

Merged

Conversation

ryzngard
Copy link
Contributor

No description provided.

@ryzngard ryzngard requested a review from a team as a code owner July 30, 2021 22:43
@Cosifne
Copy link
Member

Cosifne commented Jul 30, 2021

Why disable it?

@ryzngard
Copy link
Contributor Author

Why disable it?

There are lots of feedback on this behavior being undesirable in current state for most users. It will still be available as an option to turn on for those who want it. We are looking into other designs to enable this in the future.

@ryzngard ryzngard enabled auto-merge July 30, 2021 23:19
@ryzngard ryzngard merged commit 53db3fc into dotnet:release/dev17.0 Jul 31, 2021
@MartyIX
Copy link
Contributor

MartyIX commented Jul 31, 2021

@ryzngard Could you say why they find it undesirable? In a sentence or two.

@ryzngard
Copy link
Contributor Author

@ryzngard Could you say why they find it undesirable? In a sentence or two.

Absolutely. The current behavior will block the UI thread to do expensive work for getting fixable diagnostics and then determining what usings can be added. While this is fast most of the time, in cases where it's not it becomes increasingly frustrating for the user to see a dialog on every paste event. We're evaluating a new design where we can improve performance here and possibly make the work async. The feature is still available and I encourage you to turn it on :)

@ryzngard ryzngard deleted the features/disable_usings_on_paste branch July 31, 2021 22:28
@MartyIX
Copy link
Contributor

MartyIX commented Aug 1, 2021

The feature is still available and I encourage you to turn it on :)

The feature works for me great. I like it very much. I have a middle-sized project so I'm not affected by those longer delays. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants