Extract async navigation portions of https://github.com/dotnet/roslyn/pull/55635 #55891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Aug 25, 2021
| FunctionId.CommandHandler_FindAllReference, | ||
| KeyValueLogMessage.Create(LogType.UserAction, m => m["type"] = "streaming"), | ||
| cancellationToken)) | ||
| try |
There was a problem hiding this comment.
this is jus tmoving to a try/finally so all return paths call ONCompletedAsync.
There was a problem hiding this comment.
viewing this PR with whitespace off will help.
CyrusNajmabadi
commented
Aug 25, 2021
| var definitions = interfaceImpls.SelectMany( | ||
| i => GoToDefinitionHelpers.GetDefinitions( | ||
| i, solution, thirdPartyNavigationAllowed: false, cancellationToken)).ToImmutableArray(); | ||
|
|
||
| var title = string.Format(EditorFeaturesResources._0_implemented_members, |
There was a problem hiding this comment.
this entire synchronous codepath will hopefully go away in a future PR.
CyrusNajmabadi
requested review from
jasonmalinowski,
sharwell and
davidwengier
davidwengier
approved these changes
Aug 26, 2021
ghost
added this to the 
| } | ||
|
|
||
| if (presenter != null) | ||
| { | ||
| // Can only navigate or present items on UI thread. | ||
| await threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
There was a problem hiding this comment.
@CyrusNajmabadi there's a bunch of ConfigureAwait(false)es after this -- expected?
There was a problem hiding this comment.
taken offline. yes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55635 Is a bit large in the amount of change it causes (and potential risk it introduces). Thsi PR pulls out the portions of that PR that update several codepaths to be async and to avoid sync-over-async-over-sync-etc.